CareerCup

- Redundancy in Dept column. Department names should be moved to dictionary table and a relation between these two tables should be added.
- Column Age requires yearly updates. This information should be saved as birth year.
- Column names should be lower-case.
- Column Salary contains ambiguous data. Is this yearly salary in $1000? Column name should provide obvious answer.
- Table contains no surname column.
- Table contains no apparent primary key.
- Table contains no apparent primary key candidates.

what I can think of is there should be separate table of department having id->department.
So we can use id instead of the name(which occupies more space)

no primary key (name is not a unique identifier)

I can see two problem with this table
1) Instead of age store Date of Birth. So, it will give you correct age in future.
2) Instead of department name, Store Department ID from Department Table.

a

I can see two main problem with this table
1) Instead of Age, Store DOB. It will gives you accurate age in future.
2) Store Department ID from Department table.

I think primary key would have been some ID rather than name.

Agree with Zamn. Need to add a column which identifies one and only one person.

One additional thing other than what people has commented.
Salary will change based on time, we should be storing employ salary in different table with effective start and end.

Besides, what others have already highlighted, person can move from department to another department. so history should be store in other person_department_history table

CareerCup